Skip to content

info: bold dependencies of uninstalled packages#22965

Merged
MikeMcQuaid merged 1 commit into
Homebrew:mainfrom
HaraldNordgren:info-bold-uninstalled-deps
Jul 5, 2026
Merged

info: bold dependencies of uninstalled packages#22965
MikeMcQuaid merged 1 commit into
Homebrew:mainfrom
HaraldNordgren:info-bold-uninstalled-deps

Conversation

@HaraldNordgren

@HaraldNordgren HaraldNordgren commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

I ran 'brew info' on an uninstalled package and thought it looked weird that the uninstalled deps of that were not bolded.

The goal here (#22342) was to remove the red X, not to unbold them necessarily.


  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • AI was used to generate or assist with generating this PR.

Claude Code


@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One thought.

Comment thread Library/Homebrew/utils/output.rb Outdated
@HaraldNordgren HaraldNordgren force-pushed the info-bold-uninstalled-deps branch from 1c44144 to a9e32b6 Compare July 5, 2026 18:14
`brew info <formula>` marked installed dependencies with a green ✔ but
left uninstalled ones (e.g. `llvm`) as plain text, so they were easy to
miss among the ticks.

Give `pretty_install_status` a nilable `bold:` flag:

- `true`  bold every entry, installed or not
- `false` never bold any entry
- `nil`   (default) bold installed entries only

`brew info`'s header and its dependency/requirement listings pass
`bold: true`, so the formula name and all of its deps render bold whether
or not they are installed. A dependency's red ✘ still only appears when
the formula itself is installed and the dependency is missing. Add a
`pretty_unmarked` helper for the bold-but-unmarked case.
@HaraldNordgren HaraldNordgren force-pushed the info-bold-uninstalled-deps branch from a9e32b6 to 0391258 Compare July 5, 2026 18:17
@HaraldNordgren HaraldNordgren changed the title info: bold dependencies of uninstalled formulae info: bold dependencies of uninstalled packages Jul 5, 2026

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much clearer, thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jul 5, 2026
Merged via the queue into Homebrew:main with commit d98e016 Jul 5, 2026
41 checks passed
@HaraldNordgren HaraldNordgren deleted the info-bold-uninstalled-deps branch July 5, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants