Send bundle check failures to stderr#23009
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Routes brew bundle check failure diagnostics to stderr so stdout remains suitable for scripting/capture (e.g., brew bundle env --check), and updates the spec suite to enforce the new stream expectations.
Changes:
- Send unmet-dependency and guidance messages from
brew bundle checkto stderr instead of stdout. - Update
check_subcommand_specexpectations fromto_stdouttoto_stderr, including a contract check for stdout behavior in at least one failure case.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Library/Homebrew/bundle/subcommand/check.rb | Writes dependency-failure messaging to stderr and preserves stdout for success output. |
| Library/Homebrew/test/cmd/bundle/check_subcommand_spec.rb | Adjusts specs to assert failure output is emitted on stderr (and refines output stream contract coverage). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Keeps `brew bundle env --check` output usable for shell capture. - Treats unmet dependency reports as diagnostics instead of data. - Covers the failure stream contract in `check_subcommand_spec`.
5015ec1 to
ffa6c7a
Compare
cho-m
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew bundle env --checkoutput usable for shell capture.check_subcommand_spec.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex 5.5 xhigh with local review and testing.