Remove redundant T.let annotations Sorbet can infer

[dduugg]

Remove T.let type annotations that Sorbet can infer on its own, applying the autocorrections from two new rubocop-sorbet cops:

• Sorbet/RedundantTLet — constants assigned a constructor call (optionally .freeze'd), and initialize instance variables assigned directly from signature parameters.
• Sorbet/RedundantTLetForLiteral — constants assigned simple literals and frozen literal arrays.

Eight annotations across seven files are removed:

• bundle/extensions/uv.rb — regexp literal
• dev-cmd/generate-zap.rb, extend/os/linux/{install,linkage_checker,sandbox}.rb, tap.rb — frozen literal arrays
• install_steps.rb — a constructor-constant (X = Foo.new.freeze) and an initialize ivar

Why

These annotations are pure noise: Sorbet already infers the identical type, so they add maintenance cost (a type that must be kept in sync) without buying any checking. The constructor/frozen-literal cases depend on Sorbet's freeze-transparent inference (0.6.13304+); brew ships sorbet-static 0.6.13316, so the inference holds.

These two cops are new and not yet released — they come from the final version of Shopify/rubocop-sorbet#381 before it is opened for review. Landing their autocorrections here is a small, low-risk change that doubles as further public validation of the cops against a large real-world Sorbet codebase ahead of that PR's review.

brew typecheck passes with every annotation removed, confirming the inference is equivalent.

---

• Have you followed our Contributing guidelines?
• Have you checked for other open Pull Requests for the same change?
• Have you explained what your changes do?
• Have you explained why you'd like these changes included, not just what they do?
• For bug fixes, have you given step-by-step brew commands to reproduce the bug?
• Have you written new tests (excluding integration tests)?
• Have you successfully run brew lgtm (style, typechecking and tests) locally?

---

• AI was used to generate or assist with generating this PR.

AI (Claude Code) ran the two unreleased cops from a local checkout of the rubocop-sorbet branch against the brew source and applied their autocorrections. I reviewed the full diff, confirmed brew typecheck reports no errors and brew style passes on all changed files, and verified each removed annotation matches what Sorbet infers.

[Copilot]

Pull request overview

Removes redundant Sorbet T.let annotations in typed: strict Ruby code where Sorbet can infer the same types automatically, reducing noise while preserving type safety across Homebrew’s core and Linux-specific code.

Changes:

• Drop T.let(..., T::Array[String]) for frozen string-array constants in multiple files.
• Drop T.let(..., Regexp) for a regexp constant in the uv bundle extension.
• Drop redundant T.let for an initialize ivar assignment and a constructor-based constant.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
Library/Homebrew/tap.rb	Removes redundant T.let from a frozen %W[...] constant.
Library/Homebrew/install_steps.rb	Removes redundant T.let from a TemplateVersion constant and an initialize ivar assignment.
Library/Homebrew/extend/os/linux/sandbox.rb	Removes redundant T.let from a frozen string-array constant.
Library/Homebrew/extend/os/linux/linkage_checker.rb	Removes redundant T.let from a frozen %W[...] allowlist constant.
Library/Homebrew/extend/os/linux/install.rb	Removes redundant T.let from a frozen %W[...] runtime libs constant.
Library/Homebrew/dev-cmd/generate-zap.rb	Removes redundant T.let from a frozen string-array constant.
Library/Homebrew/bundle/extensions/uv.rb	Removes redundant T.let from a Regexp constant.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[MikeMcQuaid]

Nice, thanks!