Pre-stage cask downloads#23034
Merged
Merged
Conversation
8 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces “pre-staging” for cask installs by extracting cask containers during DownloadQueue fetch/stage work (when pour: true), then moving the staged result into Caskroom during the normal Cask::Installer#stage path to reduce serial staging time while keeping receipt/artifact installation timing unchanged.
Changes:
- Add
Cask::Downloadsupport for queued staging into a temp “caskroom” path with a marker to indicate readiness. - Update
Cask::Installer#stageto consume (move) a queued-staged cask directory when present, otherwise fall back to normal extraction. - Add RSpec coverage for queued staging behavior and for skipping queued staging when unpack dependencies are missing.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Library/Homebrew/cask/download.rb | Adds queued staging hooks for cask downloads, including temp staged path/marker and cleanup. |
| Library/Homebrew/cask/installer.rb | Uses queued-staged output during stage when available, with cleanup on failure. |
| Library/Homebrew/test/cask/installer_spec.rb | Adds tests to validate queued staging behavior and dependency-gated staging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
force-pushed
the
download-queue-staging-shape
branch
2 times, most recently
from
6e82544 to
8dd46b7
Compare
MikeMcQuaid
force-pushed
the
cask-download-queue-staging
branch
from
ca3a377 to
830d570
Compare
MikeMcQuaid
force-pushed
the
cask-download-queue-staging
branch
from
830d570 to
8019619
Compare
- Extract cask containers during queued fetches so installs spend less serial time in the staging phase. - Keep receipt writing and artifact installation in the normal install path so installed state does not change early. - Skip queued extraction when unpack dependencies are still missing so dependency installation ordering stays intact.
MikeMcQuaid
force-pushed
the
cask-download-queue-staging
branch
from
8019619 to
ed51803
Compare
p-linnane
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs #23033
brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex 5.5 xhigh with local review and testing.