Enable privileged tap CI containers#23051
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Homebrew’s Linux diagnostics and the brew tap-new GitHub Actions workflow template to better handle Bubblewrap sandbox failures in GitHub Actions, particularly when container execution needs additional privileges.
Changes:
- Add Linux diagnostic output suggesting
--privilegedfor GitHub Actions environments when the sandbox is unavailable. - Update
brew tap-new’s generatedtests.ymlworkflow to add container privilege options. - Add/extend specs to validate the new diagnostic and workflow generation behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Library/Homebrew/extend/os/linux/diagnostic.rb | Adds GitHub Actions-focused guidance when the Linux sandbox is unavailable. |
| Library/Homebrew/dev-cmd/tap-new.rb | Updates the generated tests.yml workflow template to include privileged container options. |
| Library/Homebrew/test/os/linux/diagnostic_spec.rb | Adds a spec covering the new diagnostic suggestion text. |
| Library/Homebrew/test/dev-cmd/tap-new_spec.rb | Updates the integration spec to assert the new workflow content. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Allow Bubblewrap user namespaces in generated GitHub Actions container jobs. - Report the matching container configuration when a GitHub Actions container prevents sandbox setup.
b9579d1 to
f9a6801
Compare
p-linnane
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex 5.6 Terra high with local review and testing.