Skip to content

Enable privileged tap CI containers#23051

Merged
MikeMcQuaid merged 1 commit into
mainfrom
tap-new-privileged-containers
Jul 12, 2026
Merged

Enable privileged tap CI containers#23051
MikeMcQuaid merged 1 commit into
mainfrom
tap-new-privileged-containers

Conversation

@MikeMcQuaid

Copy link
Copy Markdown
Member
  • Allow Bubblewrap user namespaces in generated GitHub Actions container jobs.
  • Direct GitHub Actions sandbox failures to the matching container configuration.

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • AI was used to generate or assist with generating this PR.

OpenAI Codex 5.6 Terra high with local review and testing.


Copilot AI review requested due to automatic review settings July 10, 2026 19:01
@MikeMcQuaid MikeMcQuaid enabled auto-merge July 10, 2026 19:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Homebrew’s Linux diagnostics and the brew tap-new GitHub Actions workflow template to better handle Bubblewrap sandbox failures in GitHub Actions, particularly when container execution needs additional privileges.

Changes:

  • Add Linux diagnostic output suggesting --privileged for GitHub Actions environments when the sandbox is unavailable.
  • Update brew tap-new’s generated tests.yml workflow to add container privilege options.
  • Add/extend specs to validate the new diagnostic and workflow generation behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
Library/Homebrew/extend/os/linux/diagnostic.rb Adds GitHub Actions-focused guidance when the Linux sandbox is unavailable.
Library/Homebrew/dev-cmd/tap-new.rb Updates the generated tests.yml workflow template to include privileged container options.
Library/Homebrew/test/os/linux/diagnostic_spec.rb Adds a spec covering the new diagnostic suggestion text.
Library/Homebrew/test/dev-cmd/tap-new_spec.rb Updates the integration spec to assert the new workflow content.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Library/Homebrew/dev-cmd/tap-new.rb
Comment thread Library/Homebrew/test/dev-cmd/tap-new_spec.rb
Comment thread Library/Homebrew/extend/os/linux/diagnostic.rb Outdated
- Allow Bubblewrap user namespaces in generated GitHub Actions
  container jobs.
- Report the matching container configuration when a GitHub Actions
  container prevents sandbox setup.
@MikeMcQuaid MikeMcQuaid force-pushed the tap-new-privileged-containers branch from b9579d1 to f9a6801 Compare July 11, 2026 07:17
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jul 12, 2026
Merged via the queue into main with commit a4b13d4 Jul 12, 2026
61 of 62 checks passed
@MikeMcQuaid MikeMcQuaid deleted the tap-new-privileged-containers branch July 12, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants