Skip to content

docs: remove references to removed setup_install_args#23055

Merged
p-linnane merged 1 commit into
Homebrew:mainfrom
branchv:python-docs
Jul 11, 2026
Merged

docs: remove references to removed setup_install_args#23055
p-linnane merged 1 commit into
Homebrew:mainfrom
branchv:python-docs

Conversation

@branchv

@branchv branchv commented Jul 11, 2026

Copy link
Copy Markdown
Member

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • AI was used to generate or assist with generating this PR.

Gemini 3.5 Flash provided some feedback on how best to organize the new historical context section


Language::Python.setup_install_args was completely removed in 6.0 and replaced by std_pip_args. Our docs were lagging behind, so this updates them accordingly.

  • Common-Issues.md: Removed the entire easy-install.pth section, which is no longer relevant as easy_install is long gone
  • Homebrew-and-Python.md: Removed the setup.py install reference as this shouldn't be used anymore
  • Python-for-Formula-Authors.md: Removed a lot of cruft that was added way back in 2014 to explain setup.py-related idiosyncrasies that are no longer relevant in today's pyproject.toml world. Instead, I just briefly summarized the transition from setup.py to pip but maybe that's not even useful here, not sure

Copilot AI review requested due to automatic review settings July 11, 2026 01:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Homebrew’s Python documentation to remove references to the removed Language::Python.setup_install_args helper and modernize guidance around pip/pyproject.toml packaging.

Changes:

  • Removes outdated setup.py/easy_install-era guidance and references to setup_install_args.
  • Updates examples and wording to reflect current pip/std_pip_args usage.
  • Replaces a large historical “rabbit hole” section with a shorter “Historical context” summary.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
docs/Python-for-Formula-Authors.md Removes setup_install_args discussion and rewrites packaging history/context.
docs/Homebrew-and-Python.md Removes python3 setup.py install mention; keeps guidance focused on pip.
docs/Formula-Cookbook.md Updates the Python resource install example to use pip/std_pip_args.
docs/Common-Issues.md Removes obsolete easy-install.pth linking issue section and its outdated remediation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/Formula-Cookbook.md

@p-linnane p-linnane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great updates @branchv!

@p-linnane p-linnane added this pull request to the merge queue Jul 11, 2026
Merged via the queue into Homebrew:main with commit 8901a9c Jul 11, 2026
40 checks passed
@branchv branchv deleted the python-docs branch July 11, 2026 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants