Skip rewriting Mach-O binaries when delete_rpath changes nothing#23079
Merged
MikeMcQuaid merged 1 commit intoJul 13, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MachOShim#delete_rpathalways wrote the whole binary back to disk, even when there was no matching rpath to remove.This change makes it return early when there is nothing to delete, so it no longer writes the file for a no-op. It now returns the deleted rpath, or
nilwhen nothing was deleted, which matches howArray#deleteandHash#deletebehave.Keg#delete_rpathturns that value into a boolean, so the relocation step no longer codesigns files that were never modified. This resolves theTODOthat asked to delay thewrite!call until we know we are changing the rpaths.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?AI (Claude Code) assisted in writing the code and tests.
I reviewed the change and ran brew lgtm locally