Test uninstalling casks#23097
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a regression integration test to ensure brew uninstall correctly handles uninstalling a Cask specified by file path (alongside an existing Formula uninstall scenario), aiming to prevent future failures of path-based Cask uninstalls.
Changes:
- Extends the existing uninstall integration test to install a fixture Cask via a path under a tap and then uninstall it via a path.
- Asserts both uninstall output and that installed artifacts (app bundle + caskroom state) are removed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1c05c8e to
ded27ae
Compare
botantony
approved these changes
Jul 14, 2026
bevanjkay
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add regression test to catch failures like #23086 again.
brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex 5.5 xhigh with local review and testing.