Skip to content

Test uninstalling casks#23097

Merged
MikeMcQuaid merged 1 commit into
mainfrom
cask-path-uninstall-regression
Jul 14, 2026
Merged

Test uninstalling casks#23097
MikeMcQuaid merged 1 commit into
mainfrom
cask-path-uninstall-regression

Conversation

@MikeMcQuaid

@MikeMcQuaid MikeMcQuaid commented Jul 14, 2026

Copy link
Copy Markdown
Member

Add regression test to catch failures like #23086 again.


  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • AI was used to generate or assist with generating this PR.

OpenAI Codex 5.5 xhigh with local review and testing.


Copilot AI review requested due to automatic review settings July 14, 2026 08:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a regression integration test to ensure brew uninstall correctly handles uninstalling a Cask specified by file path (alongside an existing Formula uninstall scenario), aiming to prevent future failures of path-based Cask uninstalls.

Changes:

  • Extends the existing uninstall integration test to install a fixture Cask via a path under a tap and then uninstall it via a path.
  • Asserts both uninstall output and that installed artifacts (app bundle + caskroom state) are removed.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Library/Homebrew/test/cmd/uninstall_spec.rb Outdated
@MikeMcQuaid MikeMcQuaid force-pushed the cask-path-uninstall-regression branch from 1c05c8e to ded27ae Compare July 14, 2026 08:43
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jul 14, 2026
Merged via the queue into main with commit 0916a6e Jul 14, 2026
41 checks passed
@MikeMcQuaid MikeMcQuaid deleted the cask-path-uninstall-regression branch July 14, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants