Preserve cask container metadata#23100
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression/bug in queued cask staging for API-backed installs by ensuring container metadata (including nested: and explicit type:) is preserved when constructing the Cask::Download object from API structs, so nested-container extraction occurs during DownloadQueue staging.
Changes:
- Populate
containerstanza (nested path + type) when building API-backedCaskobjects for downloads. - Add a regression spec verifying queued staging extracts a declared nested container for an API-loaded cask.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Library/Homebrew/api/cask_download.rb |
Ensures API-backed downloads retain container metadata so queued staging can extract nested containers correctly. |
Library/Homebrew/test/cask/installer_spec.rb |
Adds a regression test covering nested-container extraction when using DownloadQueue staging for an API-loaded cask. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Retain nested paths and explicit types for API-backed downloads. - Ensure queued staging extracts the declared nested container.
2540410 to
055a227
Compare
p-linnane
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23094
brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex 5.5 xhigh with local review and testing.