Start bottle downloads before dependency fetches#23105
Merged
Merged
Conversation
- Start the requested bottle after `prelude` checks but before recursive dependency enqueueing so network I/O overlaps Ruby work. - Reuse the cached-location future in `DownloadQueue` and defer staging until dependency enqueueing completes, avoiding duplicate transfers and early extraction. - Preserve direct fetch ordering and existing attestation, source, local bottle and only-dependencies paths. - This favours cold parallel downloads; warm or serial downloads gain little and later dependency failures can waste bandwidth.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts formula fetching to begin bottle downloads earlier (after prelude checks) so network I/O can overlap with Ruby dependency work, while deferring staging/extraction until dependency enqueueing finishes to avoid duplicate transfers and premature extraction.
Changes:
- Start bottle download enqueueing immediately after
prelude(when applicable) and before recursively enqueueing dependency fetches. - Re-enqueue the same bottle after dependency enqueueing to trigger the normal queued behavior (including staging when using a
DownloadQueueconfigured withpour: true). - Add/extend RSpec coverage for both the new enqueue ordering in
FormulaInstaller#enqueue_fetchand for “in-flight download promotion” behavior inHomebrew::DownloadQueue.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Library/Homebrew/formula_installer.rb |
Enqueues bottle downloads earlier (post-prelude) and defers staged handling until after dependency enqueueing. |
Library/Homebrew/test/formula_installer_spec.rb |
Adds specs asserting the new enqueue_fetch ordering with and without prelude having run. |
Library/Homebrew/test/download_queue_spec.rb |
Adds a spec asserting that an already-enqueued download can be “promoted” to staged behavior without a duplicate fetch. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
p-linnane
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
preludechecks but before recursive dependency enqueueing so network I/O overlaps Ruby work.DownloadQueueand defer staging until dependency enqueueing completes, avoiding duplicate transfers and early extraction.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex 5.6 Sol max with local review and testing.