Show application of file and data patches#23110
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes patch application output consistent by printing Applying ... for embedded patches (local file and DATA patches), matching the messaging already shown for remote/external patches.
Changes:
- Add an
EmbeddedPatch#filenameAPI and printohai "Applying #{filename}"when applying embedded patches. - Implement
filenameforLocalPatch(local patch files) andDATAPatch(__END__/DATApatches).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Library/Homebrew/embedded_patch.rb | Adds a filename abstraction for embedded patches and prints Applying ... during apply. |
| Library/Homebrew/local_patch.rb | Implements filename for local file patches to support the new Applying ... output. |
| Library/Homebrew/data_patch.rb | Implements filename for DATA/__END__ patches to support the new Applying ... output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bo98
force-pushed
the
embedded-patch-ohai
branch
from
fab4696 to
4de3af1
Compare
Member
@Bo98 is your |
Member
Author
|
No I just forgot to actually run |
Bo98
force-pushed
the
embedded-patch-ohai
branch
from
4de3af1 to
f5b06ea
Compare
MikeMcQuaid
approved these changes
Jul 14, 2026
MikeMcQuaid
left a comment
MikeMcQuaid
left a comment
Member
There was a problem hiding this comment.
Optional and not crazy about naming but differentiation might be nice
Bo98
force-pushed
the
embedded-patch-ohai
branch
from
f5b06ea to
e500d91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When applying a remote patch we print
Applying something.patch. We didn't for file & DATA patches. When installing a formula likelibssh2, this made you think it was applying less patches than it actually was.This PR fixes the inconsistency.
brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?