Skip to content

test_bot/formulae: re-enable all tests on Tier 1#23125

Merged
cho-m merged 1 commit into
mainfrom
test_bot-reenable-tests-tier1
Jul 16, 2026
Merged

test_bot/formulae: re-enable all tests on Tier 1#23125
cho-m merged 1 commit into
mainfrom
test_bot-reenable-tests-tier1

Conversation

@cho-m

@cho-m cho-m commented Jul 15, 2026

Copy link
Copy Markdown
Member

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • AI was used to generate or assist with generating this PR.

Restore running all tests on Linux. This attempts a fix of sticky bit issue by avoiding chmod +t within vendor-gems

Keep a minimal set of tests for Tier 3 macOS runners as they often fail from older versions of commands.

Copilot AI review requested due to automatic review settings July 15, 2026 16:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the test_bot portable-ruby workflow to (1) avoid GitHub Actions–specific behavior during brew vendor-gems and (2) restore running the full Homebrew test suite on Tier 1 runners while keeping a reduced set on non–Tier 1 configurations.

Changes:

  • Unset GITHUB_ACTIONS for brew vendor-gems invocations to avoid the GitHub Actions Linux sticky-bit chmod +t behavior.
  • Run full brew tests --online --coverage on Tier 1; keep --only=cask,formula on non–Tier 1.
  • Reuse a shared no_github_actions_env hash for multiple steps (including the nested brew test-bot call).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Library/Homebrew/test_bot/formulae.rb
@cho-m

cho-m commented Jul 15, 2026

Copy link
Copy Markdown
Member Author

May need a different fix if we hit permission issue running vendor-gems.

Possible ideas if this fails: undo chmod +t step in test-bot (at minimum for container.gz), skip Gzip test if sticky bit is set on test file, make Gzip unpack always remove sticky bit.

@cho-m
cho-m added this pull request to the merge queue Jul 16, 2026
Merged via the queue into main with commit c3eda20 Jul 16, 2026
67 of 68 checks passed
@cho-m
cho-m deleted the test_bot-reenable-tests-tier1 branch July 16, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants