rubocops: adjust depends_on checks for Linux - #23453
Merged
MikeMcQuaid merged 1 commit intoAug 5, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?This adjusts the
Homebrew/OSDependsOncop in two ways:The first change makes it so that declaring
depends_on :linuxis explicitly required for Linux-only casks as well (like inkoreader).The second change relaxes dependency declarations when using the
osstanza; IMO, the current check does not make a lot of sense. Consider a cask that supports both macOS and Linux, and has a URL like this:Where there is only a differentiator for the macOS artifact with the suffix
-darwin.With the current check, we would either need to declare an empty string for the
:linuxparameter like so:Or replace the
osstanza with anon_system_conditionalcall, which does not have this restriction.