Avoid nil cask versions during installation - #23499
Merged
Merged
Conversation
- Platform-specific casks can have no `version` when evaluated on an unsupported operating system. - Let upgrade detection skip `latest?` in that case so installation reaches normal platform validation instead of raising `NoMethodError`. - Cover a macOS-only cask evaluated on Linux. Fixes #23498
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a crash in Homebrew鈥檚 cask upgrade-detection path during brew install --cask when a cask evaluates to having no version on the current OS (e.g., a macOS-only cask evaluated on Linux). It ensures installation proceeds to normal platform validation instead of raising a NoMethodError.
Changes:
- Guarded
latest?checks inCask::Upgrade.outdated_caskswhencask.versioncan benil. - Added an RSpec regression test covering a macOS-only version stanza evaluated under Linux simulation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Library/Homebrew/cask/upgrade.rb |
Avoids calling latest? on a nil version during outdated-cask selection. |
Library/Homebrew/test/cask/upgrade_spec.rb |
Adds coverage for the nil-version-on-unsupported-OS scenario. |
馃挕 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
krehel
approved these changes
Aug 11, 2026
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
versionwhen evaluated on an unsupported operating system.latest?in that case so installation reaches normal platform validation instead of raisingNoMethodError.Fixes #23498
brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex 5.6 Sol xhigh with local review and testing.