Use internal JSON for update reports - #23540
Merged
Merged
Conversation
- Reuse package data already fetched by `brew update` - Avoid public bulk JSON downloads for package descriptions
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates brew update’s reporting to pull formula/cask descriptions from the internal packages JSON that brew update already fetches, avoiding reliance on the public bulk JSON endpoints for descriptions.
Changes:
- Switch update-report description lookups from public
formula.jws.json/cask.jws.jsondata toHomebrew::API::Internalper-package hashes. - Remove
ReporterHub’s now-unneeded memoized “all JSON” fetch helpers. - Update unit tests to stub internal-API lookups and guard against unexpected public JSON API access.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Library/Homebrew/cmd/update_report/reporter_hub.rb | Replaces public bulk JSON description lookups with internal packages hash lookups; removes bulk JSON helper methods. |
| Library/Homebrew/test/cmd/update-report_spec.rb | Adjusts specs to stub Homebrew::API::Internal description sources and prevent unexpected public API fetches. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
krehel
approved these changes
Aug 16, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 16, 2026
p-linnane
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew updatebrewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Codex GPT 5.6 Sol xhigh with local review and testing.