Skip to content

Use internal JSON for update reports - #23540

Merged
MikeMcQuaid merged 1 commit into
mainfrom
internal-json-update-report
Aug 16, 2026
Merged

Use internal JSON for update reports#23540
MikeMcQuaid merged 1 commit into
mainfrom
internal-json-update-report

Conversation

@MikeMcQuaid

Copy link
Copy Markdown
Member
  • Reuse package data already fetched by brew update
  • Avoid public bulk JSON downloads for package descriptions

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Codex GPT 5.6 Sol xhigh with local review and testing.


- Reuse package data already fetched by `brew update`
- Avoid public bulk JSON downloads for package descriptions
Copilot AI lite review requested due to automatic review settings August 16, 2026 16:26
@MikeMcQuaid
MikeMcQuaid enabled auto-merge August 16, 2026 16:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates brew update’s reporting to pull formula/cask descriptions from the internal packages JSON that brew update already fetches, avoiding reliance on the public bulk JSON endpoints for descriptions.

Changes:

  • Switch update-report description lookups from public formula.jws.json/cask.jws.json data to Homebrew::API::Internal per-package hashes.
  • Remove ReporterHub’s now-unneeded memoized “all JSON” fetch helpers.
  • Update unit tests to stub internal-API lookups and guard against unexpected public JSON API access.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Library/Homebrew/cmd/update_report/reporter_hub.rb Replaces public bulk JSON description lookups with internal packages hash lookups; removes bulk JSON helper methods.
Library/Homebrew/test/cmd/update-report_spec.rb Adjusts specs to stub Homebrew::API::Internal description sources and prevent unexpected public API fetches.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Aug 16, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 16, 2026
@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Aug 16, 2026
Merged via the queue into main with commit 94886d5 Aug 16, 2026
48 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the internal-json-update-report branch August 16, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants