Skip to content

Add padded bottle build prefixes - #23693

Open
MikeMcQuaid wants to merge 1 commit into
mainfrom
padded-bottle-prefixes
Open

Add padded bottle build prefixes#23693
MikeMcQuaid wants to merge 1 commit into
mainfrom
padded-bottle-prefixes

Conversation

@MikeMcQuaid

Copy link
Copy Markdown
Member
  • Record padded-prefix eligibility in bottle tab metadata while formulae retain their tag-default cellars.
  • Fetch tab metadata before rejecting a location-incompatible bottle and patch marked bottles from their literal built_prefix.
  • Keep platform-specific padded bottles as separate tags instead of collapsing them into :all.

This change is part of plans/relocatable-bottles.md


  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Codex with GPT 5.6-sol at Extra High effort, with local review and testing.


Copilot AI balanced review requested due to automatic review settings August 28, 2026 17:57
@MikeMcQuaid
MikeMcQuaid enabled auto-merge August 28, 2026 17:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds platform-specific padded bottle prefixes and metadata across Homebrew鈥檚 bottle creation, merging, and pouring pipeline.

Changes:

  • Defines canonical 64-byte prefixes and records padded-prefix eligibility in bottle tabs.
  • Uses bottle metadata to validate and relocate padded bottles.
  • Prevents padded platform bottles from collapsing into :all bottles and adds coverage.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Library/Homebrew/global.rb Defines padded prefix constants.
Library/Homebrew/utils/bottles.rb Maps bottle tags to padded prefixes.
Library/Homebrew/tab/tab.rb Serializes padded-prefix metadata.
Library/Homebrew/bottle_specification.rb Checks padded bottle compatibility.
Library/Homebrew/bottle.rb Applies tab metadata to bottle locations.
Library/Homebrew/formula_installer.rb Fetches metadata and relocates padded bottles.
Library/Homebrew/dev-cmd/bottle.rb Generates and merges padded bottle metadata.
Library/Homebrew/plans/relocatable-bottles.md Updates the migration plan.
Library/Homebrew/test/utils/bottles/tag_spec.rb Tests padded tag prefixes.
Library/Homebrew/test/tab_spec.rb Tests metadata serialization.
Library/Homebrew/test/formula_installer_spec.rb Tests padded bottle pouring.
Library/Homebrew/test/dev-cmd/bottle_spec.rb Tests output and merge behavior.
Library/Homebrew/test/bottle_specification_spec.rb Tests padded location compatibility.

馃挕 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread Library/Homebrew/bottle.rb Outdated
Comment thread Library/Homebrew/formula_installer.rb Outdated
@MikeMcQuaid
MikeMcQuaid force-pushed the padded-bottle-prefixes branch 2 times, most recently from b8e2258 to eb5efa5 Compare August 29, 2026 07:21
- Record padded-prefix eligibility in bottle tab metadata while formulae
  retain their tag-default cellars.
- Fetch tab metadata before rejecting a location-incompatible bottle and
  retain that bottle for dependency resolution.
- Keep platform-specific padded bottles as separate tags instead of
  collapsing them into `:all`.

This change is part of [`plans/relocatable-bottles.md`](https://github.com/Homebrew/brew/blob/HEAD/Library/Homebrew/plans/relocatable-bottles.md)
@MikeMcQuaid
MikeMcQuaid force-pushed the padded-bottle-prefixes branch from eb5efa5 to f01c0ec Compare August 29, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants