Stop fetching bottle manifests when creating tabs - #23760
Merged
Conversation
- `Formula#bottle` now checks `compatible_locations?`, which fetches the bottle manifest when the tab metadata is not yet cached. - `Tab.create` runs inside the build sandbox and called this for every runtime dependency, so formulae with a `fetch` phase failed to install once the sandbox denied the cache write. - The dependency's rebuild number only depends on the bottle spec for the current tag, so read it without the location check. Fixes #23759
4 tasks
carlocab
approved these changes
Sep 3, 2026
Contributor
There was a problem hiding this comment.
馃煝 Approval recommended
The focused change fixes the sandbox failure while preserving tag-specific rebuild metadata and includes appropriate regression coverage.
Pull request overview
Prevents bottle manifest fetches while recording dependency metadata in installation tabs.
Changes:
- Reads rebuild numbers directly from the bottle matching the current platform tag.
- Adds regression coverage ensuring location compatibility is not checked.
File summaries
| File | Description |
|---|---|
Library/Homebrew/tab.rb |
Avoids compatibility checks when recording bottle rebuilds. |
Library/Homebrew/test/tab_spec.rb |
Tests rebuild recording without location checks. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
馃挕 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
cho-m
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formula#bottlenow checkscompatible_locations?, which fetches the bottle manifest when the tab metadata is not yet cached.Tab.createruns inside the build sandbox and called this for every runtime dependency, so formulae with afetchphase failed to install once the sandbox denied the cache write.Fixes #23759
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Claude with Fable at High effort, with local review and testing.