Slim down and tighten AGENTS.md - #23778
Merged
Merged
Conversation
- Agents keep adding single-use methods and variables and widening diffs, so state the inlining, DRY, YAGNI and minimal diff guidance up front next to the `brew lgtm` instruction. - Hedges such as "where possible" and "when practical" let agents talk themselves out of the guidance, so drop them and make `T.must`, `T.unsafe` and `.send` outright forbidden. - Regroup the file into short sections, fold duplicate key guidelines into them and add the Git, TDD, shell redirect and UK spelling conventions agents otherwise get wrong.
Contributor
There was a problem hiding this comment.
馃煝 Approval recommended
The documentation-only changes are consistent, accurate and aligned with repository tooling.
Pull request overview
Tightens and reorganises contributor guidance for coding agents.
Changes:
- Prioritises minimal, DRY changes and verification.
- Adds concise command, Git, code and testing conventions.
- Consolidates repository structure guidance.
File summaries
| File | Description |
|---|---|
AGENTS.md |
Reorganises and strengthens agent contribution instructions. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
馃挕 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
p-linnane
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtminstruction.T.must,T.unsafeand.sendoutright forbidden.brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Claude with Fable at Extra High effort, with (lots of) local review, editing and testing.