api/formula/formula_struct_generator: defer placeholder replacement

[cho-m]

This method runs FormulaStruct.from_hash at the end which will call ::Formula.deep_remove_placeholders. The latter detects if generating JSON so that placeholders are preserved until loaded by user.

brew/Library/Homebrew/api/formula_struct.rb

Lines 12 to 13 in 8d49bd0

	def self.from_hash(formula_hash)
	formula_hash = ::Formula.deep_remove_placeholders(formula_hash)

brew/Library/Homebrew/api_hashable.rb

Lines 29 to 30 in 8d49bd0

	def deep_remove_placeholders(value)
	return value if generating_hash?

---

• Have you followed our Contributing guidelines?
• Have you checked for other open Pull Requests for the same change?
• Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
• Have you explained why you'd like these changes included, not just what they do?
• For bug fixes, have you given step-by-step brew commands to reproduce the bug?
• Have you written new tests (excluding integration tests)? Here's an example.
• Have you successfully run brew lgtm (style, typechecking and tests) locally?

---

• I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

---

[MikeMcQuaid]

Thanks!

[Copilot]

🟢 Approval recommended

The delegated behavior matches FormulaStruct.from_hash semantics and is adequately tested.

Pull request overview

Defers placeholder replacement to FormulaStruct.from_hash, preserving placeholders during API JSON generation.

Changes:

• Removes eager caveat placeholder replacement.
• Adds coverage for recursive replacement and JSON-generation preservation.
• Consolidates generator tests around shared setup.

File summaries

File	Description
Library/Homebrew/api/formula/formula_struct_generator.rb	Delegates placeholder handling to FormulaStruct.
Library/Homebrew/test/api/formula/formula_struct_generator_spec.rb	Tests placeholder behavior and refactors setup.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Balanced

---

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.