Move formula Bundler defaults to superenv - #23786
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
馃煛 Changes recommended
The newly centralised Bundler behaviour needs direct Superenv regression coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Moves shared Bundler defaults into Superenv so formula builds and nested Bundler calls inherit consistent settings.
Changes:
- Configures Bundler鈥檚 platform, version and excluded groups through Superenv.
- Removes redundant configuration commands from generated Ruby formulae.
File summaries
| File | Description |
|---|---|
Library/Homebrew/formula_creator.rb |
Removes per-formula Bundler defaults. |
Library/Homebrew/extend/ENV/super.rb |
Adds shared Bundler environment defaults. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
馃挕 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put all common defaults in our superenv (similar to Python, Cargo, etc. environment variables). This avoids having to add these to every Bundler-installed formula we distribute. And sets our preferred defaults for any nested calls to Bundler.
Switching to
:-separatedBUNDLE_WITHOUTfor better compatibility with older Bundler (in case any formulae are using old system Bundler).BUNDLE_PATHremains as it differs in fetch vs. install. In Bundler 5, we will likely need to moveBUNDLE_PATHfrom fetch to install phase due to changes.brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?