Skip to content

Move formula Bundler defaults to superenv - #23786

Merged
cho-m merged 1 commit into
mainfrom
superenv-bundler-defaults
Sep 4, 2026
Merged

Move formula Bundler defaults to superenv#23786
cho-m merged 1 commit into
mainfrom
superenv-bundler-defaults

Conversation

@cho-m

@cho-m cho-m commented Sep 4, 2026

Copy link
Copy Markdown
Member

Put all common defaults in our superenv (similar to Python, Cargo, etc. environment variables). This avoids having to add these to every Bundler-installed formula we distribute. And sets our preferred defaults for any nested calls to Bundler.

Switching to :-separated BUNDLE_WITHOUT for better compatibility with older Bundler (in case any formulae are using old system Bundler).

BUNDLE_PATH remains as it differs in fetch vs. install. In Bundler 5, we will likely need to move BUNDLE_PATH from fetch to install phase due to changes.


  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Copilot AI balanced review requested due to automatic review settings September 4, 2026 18:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃煛 Changes recommended

The newly centralised Bundler behaviour needs direct Superenv regression coverage.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Moves shared Bundler defaults into Superenv so formula builds and nested Bundler calls inherit consistent settings.

Changes:

  • Configures Bundler鈥檚 platform, version and excluded groups through Superenv.
  • Removes redundant configuration commands from generated Ruby formulae.
File summaries
File Description
Library/Homebrew/formula_creator.rb Removes per-formula Bundler defaults.
Library/Homebrew/extend/ENV/super.rb Adds shared Bundler environment defaults.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Balanced

馃挕 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread Library/Homebrew/extend/ENV/super.rb

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cho-m
cho-m added this pull request to the merge queue Sep 4, 2026
Merged via the queue into main with commit 728a353 Sep 4, 2026
60 checks passed
@cho-m
cho-m deleted the superenv-bundler-defaults branch September 4, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants