Skip to content

generate-cask-ci-matrix: skip runners the cask is disabled on - #23791

Merged
MikeMcQuaid merged 2 commits into
mainfrom
skip-ci-runners-for-disabled-casks
Sep 5, 2026
Merged

generate-cask-ci-matrix: skip runners the cask is disabled on#23791
MikeMcQuaid merged 2 commits into
mainfrom
skip-ci-runners-for-disabled-casks

Conversation

@bevanjkay

Copy link
Copy Markdown
Member
  • Casks can be disabled on some systems but not others. CI still generated jobs for those systems, where the cask can be neither audited nor installed, so they could only ever fail. filter_runners now drops any runner the cask is disabled on.
  • Separately, audit_signing only ever read deprecated?/deprecation_reason. disable! sets those while its date is in the future, but switches to disabled?/disable_reason once it passes. So make the audit resilient to this in case a contributor runs the audit directly locally.

Fixes #23789


  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

I used claude-code with Opus 5 to generate the fix, and reviewed the logic myself.

Copilot AI balanced review requested due to automatic review settings September 5, 2026 00:06

This comment was marked as outdated.

@bevanjkay
bevanjkay force-pushed the skip-ci-runners-for-disabled-casks branch from 0bde1ef to 9e41258 Compare September 5, 2026 00:30
- `disable!` sets the deprecation fields until its date passes,
  then switches to the disable fields, which the signing audit
  never read.
- So the tolerance for `because: :fails_gatekeeper_check` expired
  on the disable date, and casks disabled for other reasons still
  paid for a full download and Gatekeeper scan.
- A cask can be disabled on one system but not another, so CI
  generated jobs where it could be neither audited nor installed
  and so could only ever fail.
- Drop any runner the cask is disabled on when building the
  matrix.

Fixes #23789
@bevanjkay
bevanjkay force-pushed the skip-ci-runners-for-disabled-casks branch from 9e41258 to 9764ad5 Compare September 5, 2026 00:35
@bevanjkay
bevanjkay requested a balanced review from Copilot September 5, 2026 00:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃煝 Approval recommended

The behavioural changes are focused and tested, with only a minor maintainability comment remaining.

Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread Library/Homebrew/cask/audit.rb

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Sep 5, 2026
Merged via the queue into main with commit 08e85c4 Sep 5, 2026
67 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the skip-ci-runners-for-disabled-casks branch September 5, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

brew audit --cask --online fails if cask is disabled on one system block, but not others

4 participants