generate-cask-ci-matrix: skip runners the cask is disabled on - #23791
Merged
Conversation
bevanjkay
force-pushed
the
skip-ci-runners-for-disabled-casks
branch
from
September 5, 2026 00:30
0bde1ef to
9e41258
Compare
- `disable!` sets the deprecation fields until its date passes, then switches to the disable fields, which the signing audit never read. - So the tolerance for `because: :fails_gatekeeper_check` expired on the disable date, and casks disabled for other reasons still paid for a full download and Gatekeeper scan.
- A cask can be disabled on one system but not another, so CI generated jobs where it could be neither audited nor installed and so could only ever fail. - Drop any runner the cask is disabled on when building the matrix. Fixes #23789
bevanjkay
force-pushed
the
skip-ci-runners-for-disabled-casks
branch
from
September 5, 2026 00:35
9e41258 to
9764ad5
Compare
p-linnane
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
filter_runnersnow drops any runner the cask is disabled on.deprecated?/deprecation_reason.disable!sets those while its date is in the future, but switches todisabled?/disable_reasononce it passes. So make the audit resilient to this in case a contributor runs the audit directly locally.Fixes #23789
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?I used
claude-codewith Opus 5 to generate the fix, and reviewed the logic myself.