Skip to content

tests: Set environment variable USER if not set#5776

Merged
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
sjackman:tests-user
Feb 21, 2019
Merged

tests: Set environment variable USER if not set#5776
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
sjackman:tests-user

Conversation

@sjackman
Copy link
Copy Markdown
Contributor

@sjackman sjackman commented Feb 20, 2019

These two tests fail if the enivornment variable USER is not set:

./test/utils/user_spec.rb:6 # User should eq nil
./test/utils/user_spec.rb:22 # User#gui? when the current user is in a console session gui? should equal true
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The environment variable USER is not set in Docker by default.

These two tests fail if the enivornment variable USER is not set:

./test/utils/user_spec.rb:6 # User should eq nil
./test/utils/user_spec.rb:22 # User#gui? when the current user is in a
console session gui? should equal true
@sjackman sjackman self-assigned this Feb 20, 2019
Comment thread Library/Homebrew/dev-cmd/tests.rb Outdated
Co-Authored-By: sjackman <sjackman@gmail.com>
@MikeMcQuaid MikeMcQuaid merged commit e1c12de into Homebrew:master Feb 21, 2019
@MikeMcQuaid
Copy link
Copy Markdown
Member

Makes sense, thanks @sjackman!

@sjackman sjackman deleted the tests-user branch February 21, 2019 16:46
@lock lock bot added the outdated PR was locked due to age label Mar 23, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants