fix_dynamic_linkage: Check HOMEBREW_RELOCATE_METAVARS

[sjackman]

Only remove RPATH when HOMEBREW_RELOCATE_METAVARS is set.

See PR #5413

[woodruffw]

I think the problematic line is this one:

https://github.com/Homebrew/brew/blob/f67fad1e6e4f10d1c02cf85d3069c283648564b9/Library/Homebrew/extend/os/mac/keg_relocate.rb#L123

Since we're no longer filtering @rpath-prefixed install names, they end up getting passed through fixed_name and falling through to the bad_name case. We should either revert that regexp back to /^@(loader_|executable_|r)path/ or add an additional environment check there like:

dylibs.reject! { |fn| fn =~ /^@rpath/ } unless ENV["HOMEBREW_RELOCATE_METAVARS"]

[MikeMcQuaid]

We should either revert that regexp back to /^@(loader_|executable_|r)path/ or add an additional environment check there like:

dylibs.reject! { |fn| fn =~ /^@rpath/ } unless ENV["HOMEBREW_RELOCATE_METAVARS"]

👍

[sjackman]

I've added…

dylibs.reject! { |fn| fn =~ /^@rpath/ } unless ENV["HOMEBREW_RELOCATE_METAVARS"]