Skip to content

Backfill missing Xcode/clang version maps#6786

Closed
gfguthrie wants to merge 1 commit intoHomebrew:masterfrom
gfguthrie:master
Closed

Backfill missing Xcode/clang version maps#6786
gfguthrie wants to merge 1 commit intoHomebrew:masterfrom
gfguthrie:master

Conversation

@gfguthrie
Copy link
Copy Markdown
Contributor

@gfguthrie gfguthrie commented Nov 27, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

In #6702 we did not update this list. Let's also backfill as it seems to have been missed the last few Xcode releases.

"11.2.1" => { clang: "11.0", clang_build: 1100 },
}.freeze

def compilers_standard?
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There don't seem to have been any issues reported from having missed updating this, and I can't find where compilers_standard? is used – maybe this isn't necessary anymore? Opened the PR for discussion.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah seems the last ref was deleted some years ago now: 77c0f60

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #6787 as an alternative.

@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant