Skip to content

Bump Xcode to 11.2.1#6702

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
bayandin:patch-1
Nov 19, 2019
Merged

Bump Xcode to 11.2.1#6702
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
bayandin:patch-1

Conversation

@bayandin
Copy link
Copy Markdown
Contributor

@bayandin bayandin commented Nov 6, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Xcode 11.2 has been released https://developer.apple.com/documentation/xcode_release_notes/xcode_11_2_release_notes

Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Holding off on this until we've updated our CI nodes.

@MikeMcQuaid MikeMcQuaid self-assigned this Nov 6, 2019
@bayandin
Copy link
Copy Markdown
Contributor Author

bayandin commented Nov 6, 2019

Thanks!
Actually, maybe it will be wise to wait for 11.2.1 release, looks like it's going to happen soon, GM already published: https://developer.apple.com/documentation/xcode_release_notes/xcode_11_2_1_gm_seed_release_notes/

@bayandin
Copy link
Copy Markdown
Contributor Author

Hey @MikeMcQuaid,

Xcode 11.2.1 has been released and I'm going to bump the version in this PR, but I'm not quite sure what to do with detect_version_from_clang_version: Last time I've just added a new entry

         case (DevelopmentTools.clang_version.to_f * 10).to_i
         when 0       then "dunno"
         when 60      then "6.0"
         when 61      then "6.1"
         when 70      then "7.0"
         when 73      then "7.3"
         when 80      then "8.0"
         when 81      then "8.3"
         when 90      then "9.2"
         when 91      then "9.4"
         when 100     then "10.2.1"
         when 110     then "11.0"
         when 111     then "11.1"
-        else              "11.1"
+        when 112     then "11.2"
+        else              "11.2"
         end

without really checking what (DevelopmentTools.clang_version.to_f * 10).to_i returns (for Xcode 11.2).

Now I've updated Xcode to 11.2.1 locally and (DevelopmentTools.clang_version.to_f * 10).to_i returns 110. And it seems for Xcode 11.1 it returns 110 (insted of 111) as well.

@gfguthrie
Copy link
Copy Markdown
Contributor

This might've been where things have gotten off the rails – perhaps it should just be when 110 then 11.2.1 – all the other 11s should go away. It just happened to be that the version coincided with initial 11.0 release, but Apple isn't bumping the clang version with every OS release.

@bayandin bayandin changed the title Bump Xcode to 11.2 Bump Xcode to 11.2.1 Nov 13, 2019
@bayandin
Copy link
Copy Markdown
Contributor Author

This might've been where things have gotten off the rails – perhaps it should just be when 110 then 11.2.1 – all the other 11s should go away. It just happened to be that the version coincided with initial 11.0 release, but Apple isn't bumping the clang version with every OS release.

Yep, my thoughts were the same.

Force pushed 11.2.1 version

Comment thread Library/Homebrew/os/mac/xcode.rb Outdated
@MikeMcQuaid
Copy link
Copy Markdown
Member

@bayandin Need to wait for our CI nodes to be updated for this. I expect to do that next week. We've been waiting on a matching CLT version.

Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting CI upgrade.

@bayandin
Copy link
Copy Markdown
Contributor Author

Thanks!

@MikeMcQuaid MikeMcQuaid merged commit 2a45343 into Homebrew:master Nov 19, 2019
@MikeMcQuaid
Copy link
Copy Markdown
Member

CI upgraded.
Thanks so much for your contribution! Without people like you submitting PRs we couldn't run this project. You rock, @bayandin!

@bayandin bayandin deleted the patch-1 branch November 19, 2019 20:23
@bayandin
Copy link
Copy Markdown
Contributor Author

Amazing! Thank you, Mike!

@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants