Skip to content

Document external formula/casks being disallowed#7194

Closed
SMillerDev wants to merge 1 commit intoHomebrew:masterfrom
SMillerDev:docs/cask_acceptance
Closed

Document external formula/casks being disallowed#7194
SMillerDev wants to merge 1 commit intoHomebrew:masterfrom
SMillerDev:docs/cask_acceptance

Conversation

@SMillerDev
Copy link
Copy Markdown
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This unwritten rule of homebrew/core should be documented.

@MikeMcQuaid
Copy link
Copy Markdown
Member

@SMillerDev You happy with wording in #7195 or want to make that more explicit there?

@SMillerDev SMillerDev closed this Mar 20, 2020
@lock lock bot added the outdated PR was locked due to age label Apr 19, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 19, 2020
@SMillerDev SMillerDev deleted the docs/cask_acceptance branch September 21, 2022 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants