Skip to content

Tweak Acceptable Formulae#7195

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:acceptable-formulae-tweaks
Mar 20, 2020
Merged

Tweak Acceptable Formulae#7195
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:acceptable-formulae-tweaks

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid commented Mar 20, 2020

  • make clearer how self-updates should be handled
  • move from OSI to Debian approved licenses
  • don't allow open source software to depend on proprietary software

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

- make clearer how self-updates should be handled
- move from OSI to Debian approved licenses
- don't allow open source software to depend on proprietary software
Comment thread docs/Acceptable-Formulae.md
Additionally, [homebrew/core](https://github.com/Homebrew/homebrew-core) formulae must also not depend on proprietary software/casks except the following:

- macOS
- Java
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Java
- [Java](https://formulae.brew.sh/cask/java)


- macOS
- Java
- OSXFuse
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- OSXFuse
- [OSXFUSE](https://formulae.brew.sh/cask/osxfuse)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be all caps.

- macOS
- Java
- OSXFuse
- XQuartz
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- XQuartz
- [XQuartz](https://formulae.brew.sh/cask/xquartz)

Copy link
Copy Markdown
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ❤️

@MikeMcQuaid
Copy link
Copy Markdown
Member Author

Thanks for reviews, all! Passing on these changes @EricFromCanada (although I appreciate them) because we're not referring to specific casks or versions.

@MikeMcQuaid MikeMcQuaid merged commit 834935c into Homebrew:master Mar 20, 2020
@MikeMcQuaid MikeMcQuaid deleted the acceptable-formulae-tweaks branch March 20, 2020 19:38
@lock lock bot added the outdated PR was locked due to age label Apr 25, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants