Skip to content

audit whether prerelease or not#7203

Merged
MikeMcQuaid merged 3 commits intoHomebrew:masterfrom
hyuraku:audit_whether_prerelease-or-not
Mar 22, 2020
Merged

audit whether prerelease or not#7203
MikeMcQuaid merged 3 commits intoHomebrew:masterfrom
hyuraku:audit_whether_prerelease-or-not

Conversation

@hyuraku
Copy link
Copy Markdown
Contributor

@hyuraku hyuraku commented Mar 22, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Closes #7177
Check projects on GitHub whether pre-release or not.

MikeMcQuaid
MikeMcQuaid reviewed Mar 22, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great work @hyuraku!

Comment thread Library/Homebrew/dev-cmd/audit.rb Outdated
Comment thread Library/Homebrew/dev-cmd/audit.rb Outdated
@MikeMcQuaid
Copy link
Copy Markdown
Member

MikeMcQuaid commented Mar 22, 2020

Looks good! Do you have any prereleases you've found that I can use to test this?

@hyuraku
Copy link
Copy Markdown
Contributor Author

hyuraku commented Mar 22, 2020

Looks good! Do you have any prereleases you've found that I can use to test this?

I audited sysdig
The test was successful. I write the result below.

> brew audit sysdig
sysdig:
  * 0.26.5 is a GitHub prerelease
Error: 1 problem in 1 formula detected

@MikeMcQuaid MikeMcQuaid merged commit 081f6cd into Homebrew:master Mar 22, 2020
@MikeMcQuaid
Copy link
Copy Markdown
Member

MikeMcQuaid commented Mar 22, 2020

Thanks so much again for your contribution! Without people like you submitting PRs we couldn't run this project. You rock, @hyuraku!

iMichka added a commit to iMichka/brew that referenced this pull request Mar 22, 2020
@iMichka
Revert "Merge pull request Homebrew#7203 from hyuraku/audit_whether_p…
cdb9d0f 
…rerelease-or-not"

This reverts commit 081f6cd, reversing
changes made to 12d3a2a.

This fails on some formulae with:
Error: Not Found

See:
Homebrew/homebrew-core#52031
@iMichka
Copy link
Copy Markdown
Member

iMichka commented Mar 22, 2020

Hi.

I am going to revert this change:
#7205

It broke brew audit, for example brew audit octant --online fails with Error: Not Found.
This probably needs more testing.

@bayandin bayandin mentioned this pull request Mar 22, 2020
Closed
iMichka added a commit that referenced this pull request Mar 22, 2020
@iMichka
Merge pull request #7205 from iMichka/prerelease
87fcba5 
Revert "Merge pull request #7203
@hyuraku hyuraku deleted the audit_whether_prerelease-or-not branch March 23, 2020 09:52
@MikeMcQuaid
Copy link
Copy Markdown
Member

MikeMcQuaid commented Mar 25, 2020

@hyuraku Sorry we had to revert! Would you be able to look at addressing the mentioned issue and reopening a PR with fixes? Even if not: let me know, thanks!

@hyuraku
Copy link
Copy Markdown
Contributor Author

hyuraku commented Mar 26, 2020

@MikeMcQuaid
I would like to submit another PR about the issue whether GitHub prerelease or not.

@iMichka
Copy link
Copy Markdown
Member

iMichka commented Mar 26, 2020

Yes, please. Bugs happen, I think if we test it a little bit more before shipping this will be OK.

@lock lock bot added the outdated PR was locked due to age label Apr 25, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid left review comments

Assignees

No one assigned

Labels

outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create an audit to disallow pre-release versions of software in the core tap

3 participants

@hyuraku @MikeMcQuaid @iMichka