.github/workflows/tests.yml: Deploy Docker image

[sjackman]

Deploy the latest Docker image on a push to master.
Deploy a tagged Docker image upon publication of a release.

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew tests with your changes locally?

[sjackman]

GitHub Actions has failed with:

Error: No known CI provider detected! If you are using GitHub Actions or Jenkins
ghprb-plugin, then we cannot find the expected environment
variables! Check you have e.g. exported them to a Docker container.

https://github.com/Homebrew/brew/pull/7219/checks?check_run_id=534724942
That's unexpected. I don't believe that my PR could have caused this error.

[Bo98]

That always happens on the Linux runner.

The error appears to be:

Error response from daemon: No such image: brew_sut:latest

[jonchang]

I would prefer that this be a scheduled event in Homebrew/brew rather than an on-push event in Homebrew/homebrew-core. I think core is too high-volume to do something like this. (Incidentally I think that formulae.brew.sh builds should also be scheduled in that repository, rather than as an on-push build).

Never mind, I'm blind and didn't see this was in Homebrew/brew and also was related to brew tagged releases. Doesn't Docker Hub already do this for us?

% docker run -it homebrew/brew:2.2.11
Unable to find image 'homebrew/brew:2.2.11' locally
2.2.11: Pulling from homebrew/brew
fe703b657a32: Already exists 
f9df1fafd224: Already exists 
a645a4b887f9: Already exists 
57db7fe0b522: Already exists 
531c6a124820: Pull complete 
2c382c3c5cfc: Pull complete 
39e593e4e69a: Pull complete 
41117761da13: Pull complete 
72e50d2cabbb: Pull complete 
Digest: sha256:c4d8d1acf4afb61b72e05c4abe415178a3a4aae185bf352e4f89db821aa5fa8c
Status: Downloaded newer image for homebrew/brew:2.2.11
root@006e5c606a40:/home/linuxbrew# 

[MikeMcQuaid]

Seems fine but I was also under the impression Docker Hub did this for us?

[Bo98]

If I understand correctly, this is about GitHub Packages rather than Docker Hub.

[sjackman]

Currently this PR is for GitHub Packages (GHP). My intention is to replace Docker Hub, to simplify and standardize on GitHub Actions.

[dawidd6]

Currently pulling images from Github Packages Registry requires authentication, so I don't think it's good for users yet.

[sjackman]

Currently pulling images from Github Packages Registry requires authentication, so I don't think it's good for users yet.

I don't believe that's true. See https://github.com/Homebrew/brew/packages/29947

My plan is for GitHub Actions to push to both GitHub Packages Registry and Docker Hub. Once that's working, I'll disable Docker Hub Automated Build.

[dawidd6]

See: https://github.community/t5/GitHub-Actions/docker-pull-from-public-GitHub-Package-Registry-fail-with-quot/m-p/32888#M1294

[SMillerDev]

running: docker pull docker.pkg.github.com/homebrew/brew/brew:2.2.11

Error response from daemon: Get https://docker.pkg.github.com/v2/homebrew/brew/brew/manifests/2.2.11: no basic auth credentials