audit whether GitHub prerelease or not#7231
Merged
MikeMcQuaid merged 6 commits intoHomebrew:masterfrom Apr 13, 2020
Merged
Conversation
dawidd6
reviewed
Mar 28, 2020
MikeMcQuaid
requested changes
Mar 28, 2020
| when %r{^https://github.com/} | ||
| _, owner = URI.parse(stable.url).path.split("/") | ||
| tag = stable.specs[:tag] || stable.version.to_s | ||
| if GitHub.open_api("#{GitHub::API_URL}/repos/#{owner}/#{stable.full_name}/releases/tags/#{tag}")["prerelease"] |
Member
There was a problem hiding this comment.
Need to handle if this URL isn't found. You can reproduce this locally by editing the URL and ensuring it doesn't fail with a known-bad URL.
Contributor
|
I would also suggest checking if a tag/release marked as |
MikeMcQuaid
changed the title
MikeMcQuaid
reviewed
Apr 1, 2020
MikeMcQuaid
reviewed
Apr 1, 2020
bayandin
reviewed
Apr 2, 2020
MikeMcQuaid
approved these changes
Apr 12, 2020
MikeMcQuaid
force-pushed
the
audit_github-prerelease_or_not
branch
from
5a387cf to
afa5713
Compare
Member
|
Thanks @hyuraku! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?Solve #7177
Audit whether formula is GitHub prerelease or not