Skip to content

Fix installing taps in brew install.#8875

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
reitermarkus:cask-install-taps
Oct 7, 2020
Merged

Fix installing taps in brew install.#8875
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
reitermarkus:cask-install-taps

Conversation

@reitermarkus
Copy link
Copy Markdown
Member

@reitermarkus reitermarkus commented Oct 7, 2020

Partially reverts f54b458.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Re-add previous tapping logic.

Closes #8830.

@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks for this ❤️

@MikeMcQuaid MikeMcQuaid merged commit 588f5f1 into Homebrew:master Oct 7, 2020
@reitermarkus reitermarkus deleted the cask-install-taps branch October 8, 2020 03:14
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 3, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

brew install external/tap/formula when external/tap is not tapped fails with "No available formula or cask"

3 participants