Remove Intel macOS support from installer - #1140
Merged
Merged
Conversation
- Homebrew on macOS is now Apple Silicon only, so abort on any other architecture before prompting for `sudo` and always install to `/opt/homebrew`, dropping the `/usr/local` prefix and its `paths.d` special case. - Apple Silicon Macs require macOS 11 or newer, so the checks for macOS 10.7, 10.11 and 10.13 and the `version_gt` helper were unreachable. - Point CI at `/opt/homebrew/bin`: the arm64 runners never used `/usr/local`.
Contributor
There was a problem hiding this comment.
馃煛 Changes recommended
The GITHUB_PATH entry must contain only /opt/homebrew/bin, not a colon-separated path list.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Restricts macOS installation to Apple Silicon and removes obsolete Intel and legacy macOS logic.
Changes:
- Reject unsupported macOS architectures before requesting sudo.
- Standardize installation under
/opt/homebrew. - Update CI for the Apple Silicon Homebrew path.
File summaries
| File | Description |
|---|---|
install.sh |
Removes Intel macOS support and unreachable legacy checks. |
.github/workflows/tests.yml |
Updates CI paths, but incorrectly writes a colon-separated path list to GITHUB_PATH. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
p-linnane
approved these changes
Sep 4, 2026
MikeMcQuaid
marked this pull request as draft
September 4, 2026 16:13
ZhongRuoyu
approved these changes
Sep 7, 2026
|
Is it still possible to run older versions or is there going to be a day when homebrew won't be usable on intel macs at all? |
Member
Author
|
@b3z It won't run at all in one year from now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sudoand always install to/opt/homebrew, dropping the/usr/localprefix and itspaths.dspecial case.version_gthelper were unreachable./opt/homebrew/bin: the arm64 runners never used/usr/local.