Preserve dylib use-command flags when renaming - #1031
Merged
Conversation
There was a problem hiding this comment.
馃煝 Approval recommended
All reviewed changes are covered by regression tests with no unresolved issues.
Pull request overview
Preserves dylib use-command metadata when renaming install names.
Changes:
- Retains command types and flags during replacement.
- Adds regression tests for weak-link and delayed-initialization flags.
File summaries
| File | Description |
|---|---|
lib/macho/macho_file.rb |
Preserves existing dylib-use flags in replacement commands. |
test/test_macho.rb |
Verifies command types, versions, and flags remain intact. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Caleb Xu <calebcenter@live.com> Assisted-by: OpenCode (GPT-5.6 Terra)
alebcay
force-pushed
the
dylib-use-command-flags
branch
from
September 7, 2026 04:51
9f82814 to
6528c5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LC_DYLIB_USE_COMMANDflags during dylib renames.LC_LOAD_DYLIB.