Skip to content

fix(ci): authenticate protected Tier B previews#522

Merged
HomenShum merged 1 commit into
mainfrom
fix/tier-b-preview-bypass
Jul 14, 2026
Merged

fix(ci): authenticate protected Tier B previews#522
HomenShum merged 1 commit into
mainfrom
fix/tier-b-preview-bypass

Conversation

@HomenShum

Copy link
Copy Markdown
Owner

Summary

  • authenticate Tier B Playwright against protected exact-head Vercel previews
  • scope bypass headers to the exact preview origin with Chromium CDP Fetch interception
  • add an executable two-origin redirect test proving the bypass never follows a cross-origin 302
  • disable Vercel Toolbar injection for automation and suppress traces whenever a bypass secret exists
  • align canonical Home, honest live Chat/Inbox, and dynamic avatar pulse assertions with current shipped behavior
  • make release contracts and redirect-security coverage run in always-on required CI lanes

Security

An independent review reproduced Playwright route.continue({ headers }) propagating a secret across redirect hops. This patch does not use Playwright route/global header APIs. CDP overrides are applied per paused request only when its origin exactly matches the preview origin. A local two-origin test proves origin A receives a dummy header and redirected origin B does not.

Verification

  • protected exact-head preview: 12 passed, 1 honest source-chip skip, 0 failed
  • required Runtime smoke exact list: 153 passed, 1 existing skip
  • always-run Chromium launch/security gate: 37/37 passed
  • release workflow contracts: 3/3 passed
  • TypeScript: passed
  • production build/PWA: passed
  • Prettier and git diff --check: passed

No admin bypass; merge remains CI-gated per P0.

@vercel

vercel Bot commented Jul 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
nodebench-ai Ignored Ignored Jul 14, 2026 11:04am

Request Review

@github-actions

Copy link
Copy Markdown

PR size advisory

This PR adds 697 lines of substantive change. CONTRIBUTING.md defines a soft limit of ~400 LOC.

If the PR is genuinely cohesive (e.g. an architecture map, a generated migration, a deletion of a dead module), no action is needed. Otherwise consider:

  • splitting into 2-3 PRs along independent concerns
  • pre-discussing the architecture change in a GitHub Discussion before merge

This is advisory — it does not block the merge.

@HomenShum HomenShum enabled auto-merge (squash) July 14, 2026 11:05
@github-actions

Copy link
Copy Markdown

✅ Dogfood Visual QA Gate: PASSED

Check Status
Screenshots 23 captured (pass)
Walkthrough 9 chapters (pass)
Key Frames 9 extracted (pass)
Scribe Steps 8 how-to steps (pass)
Build success
Artifacts

Download the dogfood-evidence-eb13c97 artifact from the Actions tab for full screenshots, frames, and walkthrough video.


Generated by Dogfood QA Gate

@HomenShum HomenShum merged commit ad2b26c into main Jul 14, 2026
14 checks passed
@HomenShum HomenShum deleted the fix/tier-b-preview-bypass branch July 14, 2026 11:10
@github-actions

Copy link
Copy Markdown

Demo: walkthrough of the surfaces this PR changed is available as a workflow artifact (pr-demo-522) at https://github.com/HomenShum/NodeBenchAI/actions/runs/29327967662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants