Fix executable bits and add Mixbus 9 and Mixbus32c 8 and 9 templates#210
Closed
eeickmeyer wants to merge 0 commit intoHouston4444:masterfrom
Closed
Fix executable bits and add Mixbus 9 and Mixbus32c 8 and 9 templates#210eeickmeyer wants to merge 0 commit intoHouston4444:masterfrom
eeickmeyer wants to merge 0 commit intoHouston4444:masterfrom
Conversation
Owner
|
Thanks for this. In client_templates.xml, a quote is missing line 21 after "executable=". About executables, it should be another PR, because it is not linked at all with the Mixbus templates. I answer quickly anyway:
|
Owner
|
Could you restart a PR only with Mixbus templates ? |
Author
|
I can restart with only the Mixbus templates but...
Unfortunately, I'll still have to downstream patch that as any script with a shebang ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit name is a bit wrong, should be "add mixbus 9 and mixbus32c 8 and 9," but it was late and I was tired apparenty. Since Mixbus32c is also a derivative of Ardour, it makes sense to include the two most recent versions of that as well. Also, the most recent version of Mixbus (non-32c) is 9, so this adds that as well.
Additionally, many components that should be executable are not, so this fixes that.