Skip to content

[self-audit D-H9] No default spend cap for Broad-Side on the MCP surface #231

Description

@TheAmericanMaker

Source: 2026-09-11 self-audit of v0.19.5 (commit f6f8484), finding D-H9 in the reconciled review; raw finding mech 6.2sem 5.14.
Severity: high · Disposition: fix before porting · Evidence: observed fact

Location

core/broadside.ts:1790 (max_cost default); mcp-server/server.ts:1235,2329-2340.

Defect

Pi asks the user before submitting over the estimate; MCP cannot ask and ships with no default max_cost, so a host that calls codecarto_broadside submit with the shipped config spends whatever the estimate is.

Proposed fix

Ship a non-zero default max_cost; MCP refuses a submit over it unless force is passed; make explicit max_cost: 0 spellable as 'unlimited'.

The reimplementation spec carries this as a normative rule with a named acceptance scenario.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingself-auditFiled from a CodeCartographer self-audit run

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions