fix: status names a complete phase whose report is not on disk, and the README says what to commit - #302
Merged
Merged
Conversation
…he README says what to commit status.yaml is committed and records which phases are complete; the reports those phases wrote are gitignored by default (on every install path since #229). A teammate's fresh clone therefore says "6/7 complete" about findings it does not have, and nothing said so. The default stays — the ignore list was extended deliberately in 0.19.6, and the spec left "commit findings by default?" as a maintainer decision — but the divergence is no longer silent: listMissingCompletedOutputs names every complete phase whose primary output is absent, and both codecarto_status and /codecarto-status print the list (Pi's notice becomes a warning; MCP adds missingOutputs to the payload). README gains a "What to commit" section stating the policy, the consequence, and the per-workspace opt-out (#259). Closes #259. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
TheAmericanMaker
force-pushed
the
fix/259-findings-gitignore
branch
from
September 12, 2026 05:53
ef406a2 to
3b44f9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #259 (D-M16, "port differently").
What the issue asked, and what this does
The issue's fix is "pick one policy (findings committed by default, documented opt-out) and apply it on both install paths". Half of that landed in 0.19.6: since #229 both install paths write the same
.gitignore. The other half — flipping the default to commit findings — is a product decision the maintainer made the opposite way in the same release (the ignore list was extended to cover the two deep-audit reports), and the spec carries it asneeds-maintainer-decision. So this PR keeps ignore-by-default and removes the silent part of the problem:listMissingCompletedOutputs(state)/describeMissingCompletedOutputs(missing)incore/pipeline.ts: every phase status.yaml markscompletewhoseprimary_outputis not on disk.codecarto_statusprints the list after the scaffold notice and addsmissingOutputstostructuredContent;/codecarto-statusprints the same lines in the widget and its notice becomes a warning. Line-for-line parity is tested.findings/…lines from the workspace's.codecarto/.gitignore).If you'd rather flip the default, it is a template edit (
.codecarto/templates/gitignore+ the byte-identical.codecarto/.gitignore) and a README sentence; this PR's check stays useful either way (it also catches a report deleted by hand).Tests
tests/missing-completed-outputs.test.mjs(3 new; suite 724/724; all 3 fail on the pre-fix code): the helper on a fresh workspace (nothing) and after complete-then-delete (one entry); MCP status text + payload, and silence once the report is back; Pi widget lines equal MCP's and the notice level iswarning.🤖 Generated with Claude Code