Fix repeat collapsing and harden Flask secret fallback#3
Merged
Conversation
Implement real repeat-collapsing behavior in feedback viewer and filtered API paths, fix identity handling in repeating analysis for exact duplicates, replace static FLASK secret fallback with generated token, and add regression tests for repeat collapsing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes two behavior issues that directly affect reliability in the app review flow: repeating feedback was not actually being hidden when requested, and the Flask secret fallback used a static development value.
What changed
/feedbackpage rendering/api/feedback/filteredAPI filteringcollapse_repeating_feedback_items) that keeps one representative item per repeating cluster while preserving unique items.FLASK_SECRET_KEYfallback with a generated secure token (secrets.token_hex(32)).printcalls in Fabric state sync logging with structured logger calls.tests/test_utils_repeating.py.Validation
python -m unittest discover -s testspython -m compileall src testsNotes for reviewers
The repeat-collapsing behavior now runs before sorting in both server-rendered and API-filtered flows, so the Hide/Analyze toggle behaves consistently across the UI.