Stop hidden panels from processing events - #1
Open
AndyMM22 wants to merge 1 commit into
Open
Conversation
- Register ITEM_DATA_LOAD_RESULT only while the vault or curio panel is visible; it fires hundreds of times a second while the client loads item data. - Skip the WorldBoss block rebuild and the checklist rebuilds while hidden, and coalesce QUEST_LOG_UPDATE bursts. - Drop the consumable board's UNIT_AURA subscription when it hides. Visibility uses IsVisible, since a child stays shown when its window is closed.
AndyMM22
marked this pull request as draft
August 8, 2026 03:44
AndyMM22
marked this pull request as ready for review
August 8, 2026 04:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four places kept working with their panel closed.
ITEM_DATA_LOAD_RESULTfires hundreds of times a second while the client loads item data;VaultAdvisorandDelveCuriosAdvisorregistered it for the whole session. Now registered only while the relevant panel is visible, and the curio listener arms only when a request actually queued an uncached item.WorldBossrebuilt its delves block on everyQUEST_LOG_UPDATEregardless of visibility.SMCChecklistrebuilt once perQUEST_LOG_UPDATEwith no coalescing; the account checklist keyed onIsShown.ConsumableReadyBoardsubscribed toUNIT_AURAfor the session but only redraws while shown.Visibility checks use
IsVisible, since a child stays shown when its window is closed.Measurement — one client, my addon set,
C_AddOnProfilerRecentAverageTimefor the addon as a whole: 0.060ms -> 0.003ms per frame while standing idle with nothing open. That is the whole-addon average, not a claim that idle cost is now zero everywhere.One honest caveat: the visibility gates mean the two checklists no longer repaint while the window is closed, so on reopening the same tab they can be briefly stale until the next quest or currency event. In practice that is seconds of play.
Each change is independent; happy to split or drop any of them.