plan: PR-H1 — FEIGN_CLIENT role → CLIENT + HTTP_CLIENT capability#32
Merged
Conversation
Implements propose merged in #28. Sequences after PR-F1 (#31, merged) and PR-G1 (#30, merged). Hard rename — no deprecation alias, MCP bundle has no users yet and breaking changes are explicitly allowed. Single PR, ~115 LOC, ontology bump 8→9. Single source-of-truth flips at ast_java.py:91 (role) and ast_java.py:114 (HTTP_CLIENT capability); VALID_ROLES / VALID_CAPABILITIES are auto-derived so no java_ontology.py edit needed. 9 new tests in tests/test_client_role_rename.py target ~290 passed, 4 skipped (281 baseline + 9). Plan delta from propose: test #4 asserts warn-and-drop behaviour (stderr warning + override silently dropped) matching actual graph_enrich.py:443-447, 481-486, NOT raised ValueError as the propose's example suggested. Out of scope: async role/capability changes (MESSAGE_PRODUCER already covers Kafka/Rabbit/JMS), auto-promoting RestTemplate/WebClient to HTTP_CLIENT (brownfield-only opt-in), backwards-compat alias, RegisterRestClient (followup #3).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan: PR-H1 —
FEIGN_CLIENTrole →CLIENT+HTTP_CLIENTcapabilityPlans-only PR. Adds
plans/PLAN-CLIENT-ROLE-RENAME.md(423 lines).Implements propose merged in #28.
Sequence
aed732b,ONTOLOGY_VERSION = 8, 281 passed, 4 skippedHeadline decisions
ast_java.py:91—ROLE_ANNOTATIONS["FeignClient"]: "FEIGN_CLIENT"→"CLIENT"ast_java.py:114— add_TYPE_ANN_TO_CAPABILITY["FeignClient"] = "HTTP_CLIENT"VALID_ROLES/VALID_CAPABILITIESare auto-derived (java_ontology.py:16,18) → no edit neededtests/test_client_role_rename.py→ target ~290 passed, 4 skippedPlan delta from propose
Test #4 asserts warn-and-drop behaviour (stderr warning + override silently dropped) matching actual
graph_enrich.py:443-447, 481-486, NOT the raisedValueErrorshown in the propose's example. Aligns plan with reality.Out of scope (followups)
MESSAGE_PRODUCERalready covers Kafka / Rabbit / JMS)RestTemplate/WebClienttoHTTP_CLIENT(brownfield-only opt-in)FEIGN_CLIENT@RegisterRestClientMicroProfile annotation (followup Add Cursor rules and agent settings for CLI agents #3)What's in the file
Ready for Cursor + Sonnet to pick up.