Add per-PR Cursor task prompts for Tier 1 completion#4
Merged
Conversation
One copy-pasteable prompt per PR (A1, A2, A3, B, C) sized for a single Sonnet session. Each prompt is anchored to the corresponding section of PLAN-TIER1-COMPLETION.md and explicitly lists what is in scope, out of scope, and the hard requirements.
HumanBean17
added a commit
that referenced
this pull request
May 6, 2026
MCP bundle has no users yet — breaking changes are explicitly allowed. Simpler, smaller, cleaner: - Remove FEIGN_CLIENT from VALID_ROLES in the same PR (no alias) - Brownfield YAML/annotation inputs that still say FEIGN_CLIENT fail validation via the existing VALID_ROLES check; error message lists allowed roles, redirecting users to CLIENT + HTTP_CLIENT - No new helper code in graph_enrich.py (was ~15 LOC alias machinery) - LOC estimate ~120 → ~105 - Test #4 flipped from 'alias translated' to 'role rejected' - §9 [TBD] reduced from 7 → 5 (alias-specific items removed) - Risks table updated (row 1 likelihood N/A; old row 6 'alias complexity' removed)
HumanBean17
added a commit
that referenced
this pull request
May 6, 2026
* propose: FEIGN_CLIENT role → CLIENT + HTTP_CLIENT capability Add CLIENT-ROLE-RENAME-PROPOSE.md: - Rename role enum FEIGN_CLIENT → CLIENT (Spring-native vocabulary) - Add HTTP_CLIENT capability (peer to MESSAGE_PRODUCER which already exists) - Keep auto-promotion scoped exactly as today (only @FeignClient interfaces) - RestTemplate/WebClient users opt in via brownfield @CodebaseRole annotations - Two-phase deprecation alias: FEIGN_CLIENT accepted as alias for one release - Ships AFTER PR-F1 and PR-G1; ontology bump 8→9 (or 7→8 if order changes) Delete DEFERRED-REST-CLIENT-MIGRATION-PROPOSE.md: - Superseded by the new propose - Its 2026-04-26 conclusion (REST_CLIENT as capability, not role rename) is reversed by this proposal — the architecture has moved on: capabilities already exist, brownfield overrides already exist, and @CodebaseRole already lets users assign primary roles honestly. * propose: drop two-phase deprecation alias (hard rename in v1) MCP bundle has no users yet — breaking changes are explicitly allowed. Simpler, smaller, cleaner: - Remove FEIGN_CLIENT from VALID_ROLES in the same PR (no alias) - Brownfield YAML/annotation inputs that still say FEIGN_CLIENT fail validation via the existing VALID_ROLES check; error message lists allowed roles, redirecting users to CLIENT + HTTP_CLIENT - No new helper code in graph_enrich.py (was ~15 LOC alias machinery) - LOC estimate ~120 → ~105 - Test #4 flipped from 'alias translated' to 'role rejected' - §9 [TBD] reduced from 7 → 5 (alias-specific items removed) - Risks table updated (row 1 likelihood N/A; old row 6 'alias complexity' removed)
HumanBean17
added a commit
that referenced
this pull request
May 6, 2026
…ty (#32) Implements propose merged in #28. Sequences after PR-F1 (#31, merged) and PR-G1 (#30, merged). Hard rename — no deprecation alias, MCP bundle has no users yet and breaking changes are explicitly allowed. Single PR, ~115 LOC, ontology bump 8→9. Single source-of-truth flips at ast_java.py:91 (role) and ast_java.py:114 (HTTP_CLIENT capability); VALID_ROLES / VALID_CAPABILITIES are auto-derived so no java_ontology.py edit needed. 9 new tests in tests/test_client_role_rename.py target ~290 passed, 4 skipped (281 baseline + 9). Plan delta from propose: test #4 asserts warn-and-drop behaviour (stderr warning + override silently dropped) matching actual graph_enrich.py:443-447, 481-486, NOT raised ValueError as the propose's example suggested. Out of scope: async role/capability changes (MESSAGE_PRODUCER already covers Kafka/Rabbit/JMS), auto-promoting RestTemplate/WebClient to HTTP_CLIENT (brownfield-only opt-in), backwards-compat alias, RegisterRestClient (followup #3).
This was referenced May 6, 2026
Closed
This was referenced May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
plans/CURSOR-PROMPTS-TIER1.md— five copy-pasteable Cursor taskprompts, one per PR from
plans/PLAN-TIER1-COMPLETION.md. Each promptis sized to fit a single Sonnet session, lists the exact files to
attach, and explicitly enumerates in-scope / out-of-scope work and
hard requirements.
Follow-up to #2 (which merged the plan + proposals).
What's inside
master)route_overrides+@CodebaseRoute(off PR-A2; mandatory reading:PLAN-BROWNFIELD-ROLE-OVERRIDES-design-fixes.md)analyze_prMCP tool (independent after PR-A1)Plus a closing "Tips for running these in Cursor" section covering
mid-PR resumption and an optional one-line Opus diff-review prompt.
Planning artifacts only
No production code; just the prompts file.