Skip to content

Smoketest fixes to go along with the CLI updates#720

Merged
kislyuk merged 3 commits intomasterfrom
akislyuk-fix-smoketest
Dec 7, 2017
Merged

Smoketest fixes to go along with the CLI updates#720
kislyuk merged 3 commits intomasterfrom
akislyuk-fix-smoketest

Conversation

@kislyuk
Copy link
Copy Markdown
Member

@kislyuk kislyuk commented Dec 6, 2017

Test plan

Tested manually.

@ghost ghost assigned kislyuk Dec 6, 2017
@ghost ghost added code review labels Dec 6, 2017
Comment thread tests/smoketest.py Outdated
workdir.cleanup()
else:
print(f"Leaving temporary working directory at {workdir}.", file=sys.stderr)
workdir._finalizer.detach() # Disable workdir destructor
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, good catch.

Comment thread tests/smoketest.py
run("git pull --recurse-submodules", cwd="dcp-cli")
else:
run("git clone --depth 1 --recurse-submodules https://github.com/HumanCellAtlas/dcp-cli")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better.

@kislyuk kislyuk merged commit fcb0a67 into master Dec 7, 2017
@ghost ghost removed the in progress label Dec 7, 2017
@kislyuk kislyuk deleted the akislyuk-fix-smoketest branch December 7, 2017 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants