Skip to content

add testing for api_client#190

Merged
MDunitz merged 1 commit intomasterfrom
add_test
Oct 2, 2018
Merged

add testing for api_client#190
MDunitz merged 1 commit intomasterfrom
add_test

Conversation

@MDunitz
Copy link
Copy Markdown
Contributor

@MDunitz MDunitz commented Sep 20, 2018 •
edited
Loading

Need

  • To improve test coverage and ensure upload_submission_state and apiclient are tested

Approach

  • Mock _get

mweiden
mweiden approved these changes Oct 2, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@mweiden mweiden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MDunitz MDunitz merged commit 7df45c1 into master Oct 2, 2018
@MDunitz MDunitz deleted the add_test branch October 2, 2018 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mweiden mweiden mweiden approved these changes

Assignees

@MDunitz MDunitz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MDunitz @mweiden