Skip to content

add testing for api_client #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MDunitz merged 1 commit into from
Oct 2, 2018
Merged

add testing for api_client #190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 18 additions & 15 deletions test/upload/test_upload_submission_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,21 @@ def setUp(self):


@patch('hca.upload.api_client.ApiClient.checksum_status')
@patch('hca.upload.api_client.ApiClient.validation_status')
def test_validated_file_status(self, mock_validation_status, mock_checksum_status):
mock_validation_status.return_value = self.validated_response_body
@patch('hca.upload.api_client.ApiClient._get')
def test_validated_file_status(self, mock_get, mock_checksum_status):
mock_get.return_value = self.validated_response_body
mock_checksum_status.return_value = self.checksummed_response_body
valid_file = self.file_status.check_file_status('uuid', 'filename')
assert valid_file == 'VALIDATED'
mock_get.assert_called_once_with('https://upload.dev.data.humancellatlas.org/v1/area/uuid/filename/validate')

@patch('hca.upload.api_client.ApiClient.checksum_status')
def test_checksumming_scheduled_file_status(self, mock_checksum_status):
mock_checksum_status.return_value = self.checksum_scheduled_response_body

@patch('hca.upload.api_client.ApiClient._get')
def test_checksumming_scheduled_file_status(self, mock_get):
mock_get.return_value = self.checksum_scheduled_response_body
checksum_scheduled = self.file_status.check_file_status('uuid', 'filename')
assert checksum_scheduled == 'CHECKSUMMING_SCHEDULED'
mock_get.assert_called_once_with('https://upload.dev.data.humancellatlas.org/v1/area/uuid/filename/checksum')

@patch('hca.upload.api_client.ApiClient.checksum_status')
@patch('hca.upload.api_client.ApiClient.validation_status')
Expand All @@ -65,8 +68,6 @@ def test_validation_scheduled_file_status(self, mock_validation_status, mock_che
assert valid_file == 'VALIDATION_SCHEDULED'




class TestUploadAreaStatusCheck(unittest.TestCase):
def setUp(self):
self.checksums_response_body = {
Expand All @@ -87,23 +88,25 @@ def tearDownClass(clsr):
os.remove('test_status_report.txt')

@patch('hca.upload.api_client.ApiClient.checksum_statuses')
@patch('hca.upload.api_client.ApiClient.validation_statuses')
def test_get_file_statuses_correctly_sets_number_unscheduled_for_validation(self, mock_validation_statuses,
@patch('hca.upload.api_client.ApiClient._get')
def test_get_file_statuses_correctly_sets_number_unscheduled_for_validation(self, mock_get,
mock_checksum_statuses):
mock_validation_statuses.return_value = self.validations_response_body
mock_get.return_value = self.validations_response_body
mock_checksum_statuses.return_value = self.checksums_response_body

checksum_statuses, validations_statuses = self.upload_area_status_checker.get_file_statuses('upload_area_uuid')
checksum_statuses, validations_statuses = self.upload_area_status_checker.get_file_statuses('upload_area_id')
assert checksum_statuses == self.checksums_response_body
assert validations_statuses['VALIDATION_UNSCHEDULED'] == 1
mock_get.assert_called_once_with('https://upload.dev.data.humancellatlas.org/v1/area/upload_area_id/validations')

@patch('hca.upload.api_client.ApiClient.checksum_statuses')
@patch('hca.upload.api_client.ApiClient._get')
@patch('hca.upload.api_client.ApiClient.validation_statuses')
def test_report_generated_correctly(self, mock_validation_statuses, mock_checksum_statuses):
def test_report_generated_correctly(self, mock_validation_statuses, mock_get):
mock_validation_statuses.return_value = self.validations_response_body
mock_checksum_statuses.return_value = self.checksums_response_body
mock_get.return_value = self.checksums_response_body

self.upload_area_status_checker.check_file_statuses('upload_area_id', 'test_status_report')
mock_get.assert_called_once_with('https://upload.dev.data.humancellatlas.org/v1/area/upload_area_id/checksums')
assert filecmp.cmp('test_status_report.txt', 'data/mock_upload_area_status_report.txt')

if __name__ == "__main__":
Expand Down