fix: harden CLI input validation, add callgraph/logging/deploy tests,…#1067
Merged
Gbangbolaoluwagbemiga merged 1 commit intoJun 28, 2026
Merged
Conversation
… update README Closes HyperSafeD#305, HyperSafeD#521, HyperSafeD#526, HyperSafeD#527. Changes by issue: HyperSafeD#305 — README.md - Update `sanctifier analyze` CLI reference to document all flags: --timeout, --exit-code, --min-severity, --profile, --format ndjson|sarif - Refresh quick-start example (sanctifier analyze ./contracts) - Expand JSON output example to match actual schema (error_codes, rule_violations) - Note ndjson streaming mode in the output-contract section HyperSafeD#527 — runtime guards integration UX (input validation + error messages) - errors.rs: add E010 (invalid network) and E011 (missing credentials) with constructor methods and actionable hint strings; 6 new unit tests - deploy.rs: validate network against testnet|futurenet|mainnet before any I/O, return structured E010 error on bad value; replace bare eprintln+exit for the missing-credentials path with a structured E011 return - tests/deploy_validation_tests.rs: 8 integration tests covering E010/E011 rejection, hint content, and pass-through for all three valid networks HyperSafeD#526 — callgraph command correctness (integration/e2e) - tests/callgraph_tests.rs: 7 integration tests covering empty contract (0 edges), invoke_contract_check variant, multiple callers in one contract, nonexistent path exit, default output file, DOT syntax validity, and two-contract attribution HyperSafeD#521 — logging performance benchmarks + budgets - logging.rs: add make_filter(verbosity) helper for filter-build benchmarking without global side-effects; 4 unit tests including a 50 ms build-time budget - tests/logging_bench_tests.rs: 6 integration tests — 30 s wall-clock budget for quiet/verbose/JSON log modes, stderr-stream correctness for text and JSON modes, and a no-ERROR assertion for clean files in quiet mode
|
@devjayy43 is attempting to deploy a commit to the gbangbolaoluwagbemiga's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Jayy4rl Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… update README
Closes #305
Closes #521
Closes #526
Closes #527
Changes by issue:
#305 — README.md
sanctifier analyzeCLI reference to document all flags: --timeout, --exit-code, --min-severity, --profile, --format ndjson|sarif#527 — runtime guards integration UX (input validation + error messages)
#526 — callgraph command correctness (integration/e2e)
#521 — logging performance benchmarks + budgets
Summary
Describe the change, the motivation behind it, and any important implementation details.
Fixes #
Type of change
Testing
List the commands you ran and the scope of validation.
Checklist
mainand merge conflicts are resolved.