Skip to content

Add Dockerfile, health checks, and container image CI (issue #207) - #222

Merged
barreiro merged 1 commit into
Hyperfoil:mainfrom
stalep:issue_207_dockerfile
Aug 5, 2026
Merged

Add Dockerfile, health checks, and container image CI (issue #207)#222
barreiro merged 1 commit into
Hyperfoil:mainfrom
stalep:issue_207_dockerfile

Conversation

@stalep

@stalep stalep commented Jul 29, 2026

Copy link
Copy Markdown
Member

Add a minimal Dockerfile for building h5m container images with eclipse-temurin:25-jre. Add quarkus-smallrye-health for standard readiness and liveness probes at /q/health/ready and /q/health/live.

Add GitHub Actions workflow to build and publish the container image to ghcr.io/hyperfoil/h5m:latest on push to main.

@stalep
stalep force-pushed the issue_207_dockerfile branch from 0a43c24 to cfc8272 Compare July 30, 2026 17:16
@barreiro

barreiro commented Aug 5, 2026

Copy link
Copy Markdown
Member

I believe that a setup without a Dockerfile that leverages quarkus-container-image-jib extension is more appropriate for building H5M images.

It's also what's used on Horreum, although there the setup is more complex due to the support of hunter e-divise python libraries that H5M does not require.

JIB is the idiomatic Quarkus way to create container images that do not require much customization, like is the case of H5M.

it's also better in a CI environment, since it does not require docker or podman to build the image. we want the images to be built and deployed from CI only.

@stalep

stalep commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

Ok, you sold me, changing it now :)

@stalep
stalep force-pushed the issue_207_dockerfile branch from cfc8272 to b4abc97 Compare August 5, 2026 10:17
@barreiro

barreiro commented Aug 5, 2026

Copy link
Copy Markdown
Member

great!

just one thing: we don't want to push images on every commit, just on release !!

I would leave the GH action out for now. we should have something similar to branch and release actions we have on Horreum, but that is for a separate PR

…rfoil#207)

Add quarkus-smallrye-health for readiness/liveness probes at
/q/health/ready and /q/health/live.

Use quarkus-container-image-jib for building container images instead
of a Dockerfile. JIB is the idiomatic Quarkus way to create container
images — it builds images directly without requiring a Docker or
Podman daemon, which is simpler and more reliable in CI environments.

Container image properties configured in application.properties:
  quarkus.container-image.group=hyperfoil
  quarkus.container-image.name=h5m
  quarkus.container-image.registry=ghcr.io

CI workflow (.github/workflows/container.yml) simplified to a single
mvn command with -Dquarkus.container-image.build=true and
-Dquarkus.container-image.push=true. No docker/login-action or
docker/build-push-action needed — JIB handles registry authentication
via Quarkus properties.

Remove Dockerfile and .dockerignore — no longer needed with JIB.
@stalep
stalep force-pushed the issue_207_dockerfile branch from b4abc97 to c669cac Compare August 5, 2026 17:44
@barreiro
barreiro merged commit d4d9917 into Hyperfoil:main Aug 5, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants