[ethernet-view] Navbar and React Router - #116
Merged
Merged
Conversation
jmaralo
reviewed
Mar 20, 2024
jmaralo
reviewed
Mar 20, 2024
jmaralo
reviewed
Mar 20, 2024
jmaralo
reviewed
Mar 20, 2024
jmaralo
requested changes
Mar 20, 2024
andresdlt03
marked this pull request as draft
March 20, 2024 21:44
andresdlt03
marked this pull request as ready for review
March 21, 2024 11:06
jmaralo
approved these changes
Mar 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the Navbar (formerly called Sidebar, but I think this name is more correct because Sidebar is already used for charts menu and this one has a different purpose) to the ethernet view and the needed React Router code to manage different pages, TestingPage and LoggerPage as far.
I have changed some functionality on the common front; mainly, these changes have to do with the Loader component used to charge the podData and create the WsHandler. However, having this logic inside a component was problematic for React Router. So, I have changed this logic to a custom hook.