[backend][PR 2] Unit Tests / Broker Short & Logger - #126
Merged
Conversation
msanlli
marked this pull request as ready for review
May 5, 2024 15:22
jmaralo
requested changes
May 7, 2024
jmaralo
left a comment
jmaralo
left a comment
Member
There was a problem hiding this comment.
The tests should also check that the output is correct. That is, check in the mock server/client that a message is received and that the format matches the one intended.
Also I don't see the ClientMessage tests checking any output, those should also check something more meaningful
msanlli
marked this pull request as draft
May 12, 2024 15:45
msanlli
marked this pull request as ready for review
May 13, 2024 15:05
…H8/h9-software into backend/unit-tests
msanlli
changed the title
jmaralo
previously approved these changes
May 15, 2024
jmaralo
approved these changes
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit Tests - Broker Short & Logger
The unit tests check the status of the whole backend; they are divided into Short and Exhaustive tests. The Short only tests the overall and general performance, lacking edge cases or benchmarks, while the Exhaustive tests are more fine-tuned, testing all the backend functions, even when not vital; it also performs Benchmark tests.
[PR 1] --> Transport Short (2024-04-27)
[PR 2] --> Broker Short (2024-05-10)
[PR 3] --> Logger Short ~ 2024-05-11