fix(logging-view): resolve four logging view issues (#601, #602, #603, #604) - #606
Merged
Merged
Conversation
- Remove Plotly's built-in "Download plot as a PNG" modebar button, which exported the raw dark on-screen canvas with no Hyperloop branding — the header's own "Export PNG" button already produces a properly themed, branded export, so two competing PNG-export paths on the same toolbar was the actual cause of the "logo missing" reports (#601). - Show a toast confirmation when a new plot is added (#602). - Make each plot's name in the right-panel "Plots" list a link that scrolls the corresponding plot into view (#603). - Add a per-plot lock toggle that freezes pan/zoom/scroll-zoom (via Plotly's fixedrange), and disables drag-to-resize, inline rename and signal drops, so the view can't be changed by accident (#604).
JavierRibaldelRio
marked this pull request as ready for review
August 3, 2026 16:26
#603 was about the exported PDF's Table of Contents page, not the app's sidebar plot list — its entries were plain text with no way to jump to the corresponding chart page. Each entry (and its page number) is now an internal jsPDF link to that chart's page, verified against a real export (link annotations with distinct /Dest page targets, one per plot).
Closing a session (the X in the Session sidebar group) reset session metadata but left every plot, loaded CSV signal, and composed operation/ transform from that session sitting in the store — dangling references to data that no longer existed. clearSession now also resets studioPlots, studioFiles, studioOperations and studioTransforms.
Was top-right, inconsistent with the newer plot-added toast — moved to the same bottom-right corner/style so both read as one toast stack.
This was
linked to
issues
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the four open
<Logging-View>issues filed by @davidpascual05:modeBarButtonsToRemove: [..., "toImage"]) so there's a single, always-branded PNG export path. Verified with a real headless-browser repro before and after the fix.SessionStatusToaststyling/auto-dismiss pattern), triggered centrally fromaddStudioPlotso every entry point (toolbar, sidebar, per-series "New Plot") is covered./Destpage targets, one per plot).fixedrangeon all its axes (Plotly's native mechanism — this also makes Plotly hide the now-useless zoom/pan modebar entirely) and disables drag-to-resize, inline rename, and signal drag-and-drop onto that plot, so its view can't be changed by accident. Hover/tooltips keep working.Bonus (not a reported issue, but a natural companion to #603): each plot's name in the in-app right-panel "Plots" list is now also a link that scrolls the corresponding plot into view in the main area.
Test plan
All fixes were manually verified end-to-end against the real app (synthetic CSV session, headless Chromium via Playwright), not just type-checked:
tsc -b --noEmitpasses cleaneslint .— no new warnings/errors introducedvite buildsucceeds/Dest [7/9/11 0 R ...]for 3 plots), and that the entries render in link-blue