Skip to content

[backend] logger-implementation - #69

Merged
msanlli merged 26 commits into
developfrom
backend/logger-implementation-hotfix
Dec 21, 2023
Merged

[backend] logger-implementation#69
msanlli merged 26 commits into
developfrom
backend/logger-implementation-hotfix

Conversation

@msanlli

@msanlli msanlli commented Dec 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

The logger implementation has raised some problems:

  • The "keys" concept in parallel to the Logger interface
  • How to pass the BoardsMap to the messages sublogger following the Logger interface
  • Test for the logger

@msanlli
msanlli requested a review from jmaralo December 6, 2023 21:16
@msanlli msanlli self-assigned this Dec 6, 2023
@msanlli msanlli linked an issue Dec 6, 2023 that may be closed by this pull request
Integrate Logger #62
Closed
jmaralo
jmaralo reviewed Dec 7, 2023
View reviewed changes

@jmaralo jmaralo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment about naming, the rest looks good

Comment thread backend/pkg/logger/logger.go Outdated
@msanlli
msanlli requested a review from jmaralo December 11, 2023 16:42
jmaralo
jmaralo requested changes Dec 11, 2023
View reviewed changes
Comment thread backend/cmd/main.go Outdated
Comment thread backend/cmd/main.go Outdated
Comment thread backend/cmd/main.go Outdated
Comment thread backend/pkg/abstraction/logger.go Outdated
@msanlli
msanlli requested a review from jmaralo December 12, 2023 16:37
jmaralo
jmaralo previously approved these changes Dec 15, 2023
View reviewed changes
@msanlli
msanlli marked this pull request as ready for review December 15, 2023 17:29
@msanlli
msanlli changed the base branch from main to develop December 15, 2023 17:29
@msanlli
msanlli dismissed jmaralo’s stale review December 15, 2023 17:29

The base branch was changed.

@msanlli
msanlli requested a review from jmaralo December 15, 2023 17:29
@msanlli
msanlli merged commit 9bdea08 into develop Dec 21, 2023
@msanlli
msanlli deleted the backend/logger-implementation-hotfix branch December 21, 2023 18:18
@msanlli
msanlli restored the backend/logger-implementation-hotfix branch December 21, 2023 18:19
@msanlli
msanlli deleted the backend/logger-implementation-hotfix branch December 21, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmaralo jmaralo jmaralo approved these changes

Assignees

@msanlli msanlli

Labels

Backend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Integrate Logger

2 participants

@msanlli @jmaralo